Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gitignore] Add compiler-rt and rust-installer #43817

Closed
wants to merge 1 commit into from
Closed

[gitignore] Add compiler-rt and rust-installer #43817

wants to merge 1 commit into from

Conversation

behnam
Copy link
Contributor

@behnam behnam commented Aug 12, 2017

After a fresh checkout and build, these two directories are left in the
repo without being ignored by git. Looks like they are only build
artifacts and it's safe to add them to .gitignore.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@behnam behnam force-pushed the gitignore branch 2 times, most recently from cc3c337 to 2d71fe0 Compare August 12, 2017 00:44
@behnam
[gitignore] Add compiler-rt and rust-installer
2d71fe0 
After a fresh checkout and build, these two directories are left in the
repo without being ignored by git. Looks like they are only build
artifacts and it's safe to add them to `.gitignore`.
@kennytm
Copy link
Member

kennytm commented Aug 12, 2017

These are not build artifacts, but old submodules which have been removed from the repo (src/rust-installer was removed in #41843, src/compiler-rt in #42899). You could safely delete them (rm -rf) and they won't come back.

@behnam
Copy link
Contributor Author

behnam commented Aug 12, 2017

Huh! It feels like I keep getting them back, but not sure how. So let's close this and I'll report back if I find them again.

Thanks! :)

@behnam behnam closed this Aug 12, 2017
@gaurikholkar-zz
Copy link

This happens with me too but I guess rm -rf did the work for now.

@behnam behnam deleted the gitignore branch August 30, 2017 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@behnam @rust-highfive @kennytm @gaurikholkar-zz @brson